Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackers blocked animations and cookies animations playing inconsistently #5516

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Jan 22, 2025

Task/Issue URL: https://app.asana.com/0/1200905986587319/1209217680221694/f

Description

Cancelled the coroutine scope when the view is detached.

Steps to test this PR

Code review.

NO UI changes

Copy link
Contributor Author

anikiki commented Jan 22, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@anikiki anikiki marked this pull request as ready for review January 22, 2025 22:26
@anikiki anikiki changed the title Cancelled the coroutine scope when the view is detached. Trackers blocked animations and cookies animations playing inconsistently Jan 22, 2025
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job finding this @anikiki !

@anikiki anikiki merged commit db2fdfd into develop Jan 23, 2025
9 checks passed
@anikiki anikiki deleted the bugfix/ana/trackers_blocked_animations_and_cookies_animations_playing_inconsistently branch January 23, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants