Avoid auth v2 refresh token reuse on JWKs fetch error #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmac012
force-pushed
the
fix/lukasz/auth-v2-jwks-fetch-error-handling
branch
from
75f6de8 to
5dc5fb8
Compare
anikiki
pushed a commit
that referenced
this pull request
Jan 23, 2025
Task/Issue URL: https://app.asana.com/0/1205648422731273/1209217826294377/f ### Description This PR ensures JWKs are fetched before refreshing auth v2 tokens. Existing refresh token may be invalidated upon obtaining new one. If fetching JWKs fails for any reason, the app can't validate and store new token and is left with an invalid refresh token. ### Steps to test this PR QA - optional ### No UI changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205648422731273/1209217826294377/f
Description
This PR ensures JWKs are fetched before refreshing auth v2 tokens. Existing refresh token may be invalidated upon obtaining new one. If fetching JWKs fails for any reason, the app can't validate and store new token and is left with an invalid refresh token.
Steps to test this PR
QA - optional
No UI changes