Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom logic for sizing autofill overflow menu popup #5548

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jan 27, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1209252957928805/f

Description

Updates the password management screen so that popup menus (triggered from a password’s overflow menu) take on the default size instead of specifying a custom width.

Steps to test this PR

  • On a phone, visit Settings->Passwords, manually add a password, then return to the password list view.
  • Tap on the password’s overflow, and verify the sizing of the popup menu looks ok
  • Flip to landscape, and check it still looks good.
  • As a final check, keep it in landscape and leave the screen. re-enter password management screen and check the overflow size is still good.
  • Repeat on a tablet.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CDRussell CDRussell marked this pull request as ready for review January 27, 2025 17:34
@anikiki anikiki self-assigned this Jan 27, 2025
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@CDRussell CDRussell merged commit 9ad7004 into develop Jan 27, 2025
8 checks passed
@CDRussell CDRussell deleted the feature/craig/fix_autofill_popup_menu branch January 27, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants