Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-selection: Dynamic menu #5588

Open
wants to merge 5 commits into
base: feature/ondrej/tab-multi-selection-fab
Choose a base branch
from

Conversation

0nko
Copy link
Member

@0nko 0nko commented Feb 3, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209118961868655

Description

This PR adds a dynamic menu that updates its menu items based on the selection view state.

Screen_recording_20250204_094857.mp4

The selection functionality isn’t implemented yet, so tapping on the FAB simulates different states.

  1. Selection mode with no tabs selected
  2. Selection Mode with 2 tabs selected
  3. Normal (non-selection mode)

Figma screenshots for reference:

1. 2. 3.
image image image

The menu options don't do anything except for New Tab and Close All item.

Steps to test this PR

  • Enable the tabManager / multiSelection feature flag in the settings
  • Open the tab manager
  • Notice the default menu reflects the Selection mode without selection (refer to 1.), with toolbar buttons disabled
  • Tap on the FAB
  • Notice the menu is updated to Selection mode with 2 tabs selected (refer to 2.), with toolbar buttons enabled and the number of tabs (2) reflected in the menu items
  • Tap on the FAB
  • Notice the menu is updated to Normal mode with the fire button and tab layout button (both working) and the correct menu (refer to 3.)

Copy link
Member Author

0nko commented Feb 3, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko marked this pull request as ready for review February 3, 2025 20:24
@0nko 0nko changed the title Add menus and resources Multi-selection: Dynamic menu Feb 3, 2025
@0nko 0nko mentioned this pull request Feb 10, 2025
46 tasks
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from ae833dd to 88714c8 Compare February 13, 2025 10:54
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from 974409b to 10a05be Compare February 13, 2025 10:54
@0nko 0nko requested a review from mikescamell February 13, 2025 10:58
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from 10a05be to da7bac5 Compare February 14, 2025 09:42
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 88714c8 to 3987163 Compare February 14, 2025 09:42
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from da7bac5 to ad27238 Compare February 14, 2025 14:01
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 3987163 to 195a3f0 Compare February 14, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant