Follow ups to 5626 #5638
Closed
Follow ups to 5626 #5638
+182
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/follow-ups-5626
branch
from
aa4b887 to
f1e0c8d
Compare
4 tasks
malmstein
reviewed
Feb 12, 2025
| @@ -652,7 +652,9 @@ class BrowserTabFragment : | |||
| delay(COOKIES_ANIMATION_DELAY) | |||
| } | |||
| context?.let { | |||
| omnibar.createCookiesAnimation(isCosmetic) | |||
| if ([email protected]?.maliciousSiteBlocked != true) { | |||
There was a problem hiding this comment.
this should go via ViewModel the same way viewModel.onAutoconsentResultReceived() does
| @@ -875,7 +877,7 @@ class BrowserTabFragment : | |||
| object : DefaultLifecycleObserver { | |||
| override fun onStop(owner: LifecycleOwner) { | |||
| if (isVisible) { | |||
| if (viewModel.browserViewState.value?.maliciousSiteDetected != true) { | |||
| if (viewModel.browserViewState.value?.maliciousSiteBlocked != true) { | |||
| @@ -3787,7 +3789,7 @@ class BrowserTabFragment : | |||
| omnibar.cancelTrackersAnimation() | |||
| } | |||
|
|
|||
| if (viewState.progress == MAX_PROGRESS) { | |||
| if (viewState.progress == MAX_PROGRESS && lastSeenBrowserViewState?.maliciousSiteBlocked != true) { | |||
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/follow-ups-5626
branch
from
f1e0c8d to
ab4d988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205008441501016/1209378071641065
Description
Steps to test this PR
Feature 1
Feature 2
Feature 2
UI changes