Sync: Fire accountRemoved KV store reason when no account #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1202926619870900/1209014391063056/f
iOS PR: duckduckgo/iOS#3875
macOS PR: duckduckgo/macos-browser#3782
What kind of version bump will this require?: Minor
Description:
As part of ✓ Send pixels for account removal + decoding issues, pixels were added indicating what the reason for the Sync account being removed from the Keychain was.
However, the pixel
sync_account_removed_reason_not-set-on-key-value-storeis being sent even when there was no account stored in the keychain in the first place. This could be obscuring a problem.To make this Pixel more useful, we should update it so that it's only sent when there was an account stored in the keychain.
Steps to test this PR:
Hard to test the pixel itself as reporting on a broken state, but just do a quick smoke test of Sync on both platforms.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template