Update PixelKit so that ENABLE_TESTABILITY override isn't required for PR Checks workflow run #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1203301625297703/1208100078742782/f
iOS PR: duckduckgo/iOS#3256
macOS PR: duckduckgo/macos-browser#3126
What kind of version bump will this require?: Patch
Description:
PixelKitTestingUtilities, as a regular Swift module (non-test target) shouldn't use testable imports.
This change removes a testable import from XCTestCase+PixelKit.swift in order to simplify macOS CI workflow
by removing the need to pass ENABLE_TESTABILITY=1 for xcodebuild invocations.
Steps to test this PR:
Verify that CI is green.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template