ntp: prevent gradients bleeding through

[shakyShane]

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209098832765829/f

Description

• using an overlay image ONLY was problematic for a couple of reasons.
• Due to pixel rounding, sometimes we’d see a 0.5 pixel bleed through
• We saw additional white flashes as the content type was changed

Now, I’m always setting a background color on the body, which has a nice effect of solving both of the cases above.

Testing Steps

• We tested in-place in macOS, so a code review is enough here.

Checklist

Please tick all that apply:

• I have tested this change locally
• I have tested this change locally in all supported browsers
• This change will be visible to users
• I have added automated tests that cover this change
• I have ensured the change is gated by config
• This change was covered by a ship review
• This change was covered by a tech design
• Any dependent config has been merged

[netlify]

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	75f1ac1
🔍 Latest deploy log	https://app.netlify.com/sites/content-scope-scripts/deploys/677fadb487a76200088f47a2
😎 Deploy Preview	https://deploy-preview-1382--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[shakyShane]

• ntp: prevent gradients bleeding through #1382 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

• Branch Name: pr-releases/pr-1382
• Commit Hash: f87cfce519c3a92cfe91071249e100bfe51ab17e
• Install Command: npm i github:duckduckgo/content-scope-scripts#f87cfce519c3a92cfe91071249e100bfe51ab17e

Please use the above install command to update to the latest version.

[github-actions]

[Beta] Generated file diff

Time updated: Thu, 09 Jan 2025 11:07:26 GMT

Integration

    - integration/pages/new-tab/dist/index.css

• integration/pages/new-tab/dist/index.js

File has changed

Windows

    - windows/pages/new-tab/dist/index.css

• windows/pages/new-tab/dist/index.js

File has changed

Apple

    - dist/pages/new-tab/dist/index.css

• dist/pages/new-tab/dist/index.js

File has changed

[mgurgel]

Just out of curiosity, was there a technical reason to not go with a switch or just personal preference?

[mgurgel]

👍