Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable messageBridge on Android + tests #1395

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jan 14, 2025

Asana Task/Github Issue: https://app.asana.com/0/1208671677432066/1209151039020985/f

Description

  • adds the messageBridge to android as agreed

Testing Steps

  • Extensive testing was conducted by @joshliebe on Android.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for content-scope-scripts failed.

Name Link
🔨 Latest commit e1a88c6
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6797d016b1b471000893cfdd

Copy link

github-actions bot commented Jan 14, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 14, 2025

[Beta] Generated file diff

Time updated: Mon, 27 Jan 2025 18:28:35 GMT

Android
    - android/autofillPasswordImport.js
  • android/contentScope.js

File has changed

Chrome
    - chrome/inject.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@shakyShane shakyShane force-pushed the shane/android-bridge branch from 0dfcbf1 to 3381c98 Compare January 27, 2025 10:41
@shakyShane shakyShane marked this pull request as ready for review January 27, 2025 10:44
@shakyShane shakyShane changed the title POC DO NOT MERGE enable messageBridge on Android + tests Jan 27, 2025
@shakyShane shakyShane requested a review from a team as a code owner January 27, 2025 10:44
@shakyShane shakyShane requested a review from mgurgel as a code owner January 27, 2025 18:11
Copy link
Member

@muodov muodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shakyShane shakyShane merged commit 8e76460 into main Jan 28, 2025
9 of 13 checks passed
@shakyShane shakyShane deleted the shane/android-bridge branch January 28, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants