Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duck Player: Pause video playback on “Watch on YouTube" #1424

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Jan 23, 2025

Asana Task/Github Issue: https://app.asana.com/0/1207252092703676/1207942134403719/f

Description

Pauses video playback when clicking on Watch on YouTube.

Notes:

  1. Only tested on macOS local build (branch daniel/duckplayer.open.in.youtube)

Testing Steps

  1. Run native app with C-S-S branch
  2. Play a video on Duck Player
  3. Click on Watch on YouTube
  4. Confirm that Duck Player video pauses and new tab opens on YouTube

Checklist

<!—
These questions are a friendly reminder to shipping code, if you're uncertain ask the AoR owners.
It's also totally appropriate to not check some of these boxes, if they don't apply to your change.
—>
Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 0df1964
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/679a234106772b0008b5f975
😎 Deploy Preview https://deploy-preview-1424--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 23, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 23, 2025

[Beta] Generated file diff

Time updated: Wed, 29 Jan 2025 12:47:50 GMT

Android
    - android/pages/duckplayer/dist/index.js

File has changed

Integration
    - integration/pages/duckplayer/dist/index.js

File has changed

Windows
    - windows/pages/duckplayer/dist/index.js

File has changed

Apple
    - dist/pages/duckplayer/dist/index.js
  • dist/pages/duckplayer/index.html

File has changed

@mgurgel mgurgel force-pushed the mgurgel/duckplayer-video-pause branch from bbc955e to 3c3206e Compare January 28, 2025 12:13
@mgurgel mgurgel marked this pull request as ready for review January 28, 2025 12:13
@mgurgel mgurgel requested review from shakyShane and a team as code owners January 28, 2025 12:13
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-video-pause branch from 0108e64 to cb4d651 Compare January 29, 2025 12:44
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-video-pause branch from cb4d651 to 18a1413 Compare January 29, 2025 12:45
@mgurgel mgurgel requested a review from shakyShane January 29, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants