Authv2 / Networking improvements #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -416,7 +415,7 @@ extension Pixel { | |||
| case networkProtectionTunnelFailureDetected | |||
| case networkProtectionTunnelFailureRecovered | |||
|
|
|||
| case networkProtectionLatency(quality: NetworkProtectionLatencyMonitor.ConnectionQuality) | |||
| case networkProtectionLatency(quality: String) | |||
There was a problem hiding this comment.
Changing just these allows us to remove NetworkProtection as dependency of Core and "flatten" the dependency tree, solving possible runtime issues during testing
There was a problem hiding this comment.
@diegoreymendez Do you have anything against this change? I can explain the rationale if needed.
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
alessandroboron
approved these changes
Jan 27, 2025
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 27, 2025
Task/Issue URL: https://app.asana.com/0/1205842942115003/1209170372758735/f iOS PR: duckduckgo/iOS#3820 macOS PR: duckduckgo/macos-browser#3746 What kind of version bump will this require?: Major **Description**: Networking v2 Improvements - Introduction of RetryPolicy - Authentication support improved with refresh callback in case of 401 error - Equatable conformance - Hashable Conformance - APIRequestV2Error Equatable conformance - New Oauth framework inside Networking v2 - Malicious site protection APIClient updated to Networking v2 - A lot of utilities, moks and improvements added to `NetworkingTestingUtils` Additional changes include: - `DecodableHelper` expanded and renamed `CodableHelper` - `Date` extension with utilities + unit tests - Rationalisation of the package "Testing Utils" modules, now every library has its `XYZTestingUtils` module, I removed the generic `TestingUtils`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1209170372758735/f
CC: @miasma13
Description:
Timport TestUtilsand replaced with the new dedicate test utils for each packageNetworkProtectionasCore.frameworkdependency and avoiding runtime issues during testing like:Steps to test this PR:
Definition of Done:
Internal references:
Software Engineering Expectations
Technical Design Template