Remove cache busting prefix from pixel live URL when validating

duckduckgo · Jan 10, 2025 · ab2adea · ab2adea
1 parent d03e9d1
commit ab2adea
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/params_validator.mjs b/src/params_validator.mjs
@@ -140,7 +140,8 @@ export class ParamsValidator {
 
         const urlSplit = url.split('/')[2].split('?');
         const livePixelName = urlSplit[0].replaceAll('_', '.');
-        const livePixelRequestParams = urlSplit[1];
+        // grab pixel parameters with any preciding cache buster removed
+        const livePixelRequestParams = /^([0-9]+&)?(.*)$/.exec(urlSplit[1] || '')[2]
 
         // 1) Validate pixel name if it's parameterized
         if (livePixelName.length > prefix.length) {

diff --git a/tests/live_pixel_validation_test.mjs b/tests/live_pixel_validation_test.mjs
@@ -46,6 +46,13 @@ describe('No common params nor suffixes', () => {
         const expectedErrors = ["must NOT have additional properties. Found extra property 'param2'"];
         expect(errors).to.have.members(expectedErrors);
     });
+
+    it('ignores cache buster', () => {
+        const prefix = 'simplePixel';
+        const url = `/t/${prefix}?12345&param1=true`;
+        const errors = paramsValidator.validateLivePixels(pixelDefs[prefix], prefix, url);
+        expect(errors).to.be.empty;
+    })
 });
 
 describe('Common params', () => {