Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second quarterly iOS satisfaction survey #131

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Dec 23, 2024

Task: https://app.asana.com/0/1207619243206445/1209004122571943/f

This PR adds the second quarterly satisfaction survey. This survey implements the rules listed here.

How to test:

  • Check that the survey matches the rules implemented in the Asana task
  • Check that the survey includes the correct link and parameters

Simulator Screenshot - iPhone 16 Pro Max - 2024-12-22 at 21 28 55

@samsymons samsymons requested a review from amddg44 December 23, 2024 05:13
@samsymons samsymons requested a review from a team as a code owner December 23, 2024 05:13
Copy link

@@ -80,6 +80,29 @@
"matchingRules": [
4
]
},
{
"id": "ios_quarterly_satisfaction_survey_q4_2024_part_2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to suggest a better name here - I wanted to keep it unique from the previous Q4 2024 survey.

6
],
"exclusionRules": [
1, 2, 7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This excludes the survey from being shown to anyone eligible for the PPro surveys, as well as excluding it from the new rule 7 which is checking whether previous surveys were interacted with or displayed.

Comment on lines +216 to +221
"interactedWithMessage": {
"value": [
"ddg_ios_survey_1",
"ios_quarterly_satisfaction_survey_q4_2024"
]
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant given messageShown should also be true for these values, but I decided to play it safe.

]
},
"appVersion": {
"min": "7.123.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the locale parameter makes this redundant, since the survey wouldn't get displayed on versions that don't support it, but I'm adding it here as a safeguard.

Copy link
Collaborator

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants