-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add second quarterly iOS satisfaction survey #131
base: main
Are you sure you want to change the base?
Conversation
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/pre/ios-config.json |
@@ -80,6 +80,29 @@ | |||
"matchingRules": [ | |||
4 | |||
] | |||
}, | |||
{ | |||
"id": "ios_quarterly_satisfaction_survey_q4_2024_part_2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to suggest a better name here - I wanted to keep it unique from the previous Q4 2024 survey.
6 | ||
], | ||
"exclusionRules": [ | ||
1, 2, 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This excludes the survey from being shown to anyone eligible for the PPro surveys, as well as excluding it from the new rule 7
which is checking whether previous surveys were interacted with or displayed.
"interactedWithMessage": { | ||
"value": [ | ||
"ddg_ios_survey_1", | ||
"ios_quarterly_satisfaction_survey_q4_2024" | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant given messageShown
should also be true for these values, but I decided to play it safe.
] | ||
}, | ||
"appVersion": { | ||
"min": "7.123.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the locale
parameter makes this redundant, since the survey wouldn't get displayed on versions that don't support it, but I'm adding it here as a safeguard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Task: https://app.asana.com/0/1207619243206445/1209004122571943/f
This PR adds the second quarterly satisfaction survey. This survey implements the rules listed here.
How to test: