Merge pull request #1144 from duckduckgo/jag/ducksay-fix

DuckSay: The IA has to return `call` if it's a type `self`.
duckduckgo · Oct 8, 2014 · 7974c08 · 7974c08
2 parents 56f1477 + e30c553
commit 7974c08
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/DDG/Spice/DuckSay.pm b/lib/DDG/Spice/DuckSay.pm
@@ -22,6 +22,7 @@ handle remainder => sub {
     if ($_ ne '') {
         # Skip calling reddit's API if text is given
         spice call_type => 'self';
+        return call;
     }
     return $_;
 };

diff --git a/t/DuckSay.t b/t/DuckSay.t
@@ -22,13 +22,13 @@ ddg_spice_test(
         caller => 'DDG::Spice::DuckSay'
     ),
     'ducksay hello world!' => test_spice(
-        'hello world!',
+        '/js/spice/duck_say/',
         call_type => 'self',
         is_unsafe => 1,
         caller => 'DDG::Spice::DuckSay'
     ),
     'daxsays hello world!' => test_spice(
-        'hello world!',
+        '/js/spice/duck_say/',
         call_type => 'self',
         is_unsafe => 1,
         caller => 'DDG::Spice::DuckSay'