Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window size changes #473

Open
wants to merge 1 commit into
base: ente
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions duckiebot/calibrate_extrinsics/command.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@ def command(shell: DTShell, args, **kwargs):
# launch viewer
launch_viewer(
parsed.robot,
"extrinsics_calibrator",
LAUNCHER_NAME,
verbose=parsed.vv,
window_args={
"icon": get_asset_icon_path(ICON_ASSET),
"width": 1120,
"height": 660,
},
"icon": get_asset_icon_path(ICON_ASSET)
}
)
8 changes: 3 additions & 5 deletions duckiebot/calibrate_intrinsics/command.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@ def command(shell: DTShell, args, **kwargs):
# launch viewer
launch_viewer(
parsed.robot,
"intrinsics_calibrator",
LAUNCHER_NAME,
verbose=parsed.vv,
window_args={
"icon": get_asset_icon_path(ICON_ASSET),
"width": 1120,
"height": 960,
},
"icon": get_asset_icon_path(ICON_ASSET)
}
)
8 changes: 4 additions & 4 deletions duckiebot/image_viewer/command.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@

# NOTE: this must match the name of the launcher in the dt-duckietown-viewer project
LAUNCHER_NAME = "image_viewer"
VIEWER_WINDOW_WIDTH = 702
ICON_ASSET = "icon-image-viewer.png"


class DTCommand(DTCommandAbs):
help = "Runs the image viewer"

Expand All @@ -22,10 +22,10 @@ def command(shell: DTShell, args, **kwargs):
# launch viewer
launch_viewer(
parsed.robot,
"image_viewer",
LAUNCHER_NAME,
verbose=parsed.vv,
window_args={
"icon": get_asset_icon_path(ICON_ASSET),
"width": VIEWER_WINDOW_WIDTH
},
"width": 702
}
)
12 changes: 2 additions & 10 deletions duckiebot/keyboard_control/command.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,8 @@

# NOTE: this must match the name of the launcher in the dt-duckietown-viewer project
LAUNCHER_NAME = "keyboard_controller"

VIEWER_WINDOW_WIDTH = 550
VIEWER_WINDOW_HEIGHT = 600
ICON_ASSET = "icon-keyboard-controller.png"

# NOTE: this must match the name of the launcher in the dt-duckietown-viewer project
LAUNCHER_NAME = "keyboard_controller"
ICON_ASSET = "icon-keyboard-control.png"

class DTCommand(DTCommandAbs):
help = "Runs the keyboard controller"
Expand All @@ -31,8 +25,6 @@ def command(shell: DTShell, args, **kwargs):
LAUNCHER_NAME,
verbose=parsed.vv,
window_args={
"width": VIEWER_WINDOW_WIDTH,
"height": VIEWER_WINDOW_HEIGHT,
"icon": get_asset_icon_path(ICON_ASSET),
},
"icon": get_asset_icon_path(ICON_ASSET)
}
)
5 changes: 3 additions & 2 deletions duckiebot/led_control/command.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
LAUNCHER_NAME = "led_controller"
ICON_ASSET = "icon-led-control.png"


class DTCommand(DTCommandAbs):
help = "Runs the LED controller"

Expand All @@ -21,9 +22,9 @@ def command(shell: DTShell, args, **kwargs):
# launch viewer
launch_viewer(
parsed.robot,
"led_controller",
LAUNCHER_NAME,
verbose=parsed.vv,
window_args={
"icon": get_asset_icon_path(ICON_ASSET)
},
}
)