Skip to content

Commit

Permalink
whattheduck: Fix delete copy button not clickable
Browse files Browse the repository at this point in the history
  • Loading branch information
bperel committed Jun 28, 2024
1 parent e1f10de commit 3545361
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 17 deletions.
25 changes: 21 additions & 4 deletions apps/whattheduck/android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,13 +1,30 @@
<?xml version='1.0' encoding='utf-8'?>
<?xml version='1.0' encoding='utf-8' ?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<application android:allowBackup="true" android:icon="@mipmap/ic_launcher" android:label="@string/app_name" android:roundIcon="@mipmap/ic_launcher_round" android:supportsRtl="true" android:theme="@style/AppTheme" android:usesCleartextTraffic="true">
<activity android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|smallestScreenSize|screenLayout|uiMode" android:exported="true" android:label="@string/title_activity_main" android:launchMode="singleTask" android:name=".MainActivity" android:theme="@style/AppTheme.NoActionBarLaunch">
<application
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/AppTheme"
android:usesCleartextTraffic="true">
<activity
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|smallestScreenSize|screenLayout|uiMode"
android:exported="true"
android:label="@string/title_activity_main"
android:launchMode="singleTask"
android:name=".MainActivity"
android:theme="@style/AppTheme.NoActionBarLaunch">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
<provider android:authorities="${applicationId}.fileprovider" android:exported="false" android:grantUriPermissions="true" android:name="androidx.core.content.FileProvider">
<provider
android:authorities="${applicationId}.fileprovider"
android:exported="false"
android:grantUriPermissions="true"
android:name="androidx.core.content.FileProvider">
<meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/file_paths" />
</provider>
</application>
Expand Down
25 changes: 12 additions & 13 deletions apps/whattheduck/src/components/OwnedIssueCopies.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,7 @@
</div>
<Condition :value="copies[idx].condition"
/></ion-label>
<ion-button
@click="
copies.splice(currentCopyIndex!, 1);
currentCopyIndex = currentCopyIndex! - 1 < 0 ? undefined : currentCopyIndex! - 1;
"
color="danger"
size="small"
v-if="!isOfflineMode"
>{{ t('Supprimer') }}</ion-button
></template
>
</template>
</ion-segment-button>
<ion-button
:style="{ gridColumn: 4 }"
Expand All @@ -33,8 +23,17 @@
@click="addCopy"
>
<ion-icon :ios="addOutline" :android="addSharp" />&nbsp;{{ t('Ajouter un exemplaire') }}
</ion-button>
</ion-segment>
</ion-button> </ion-segment
><ion-button
@click="
copies.splice(currentCopyIndex!, 1);
currentCopyIndex = currentCopyIndex! - 1 < 0 ? undefined : currentCopyIndex! - 1;
"
color="danger"
size="small"
v-if="currentCopyIndex !== undefined && !isOfflineMode"
>{{ t('Supprimer') }}</ion-button
>
<owned-issue-copy v-if="currentCopyIndex !== undefined" v-model="copies[currentCopyIndex]" />
</ion-col>
</ion-row>
Expand Down

0 comments on commit 3545361

Please sign in to comment.