Implement initial iteration of Python bindings for imap-codec
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenningHolmDE
changed the title
imap-codec
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
from
d77173a to
e7d5076
Compare
Pull Request Test Coverage Report for Build 9645169959Details
💛 - Coveralls |
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
from
e7d5076 to
6d31177
Compare
Pull Request Test Coverage Report for Build 9669612084Details
💛 - Coveralls |
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
from
6d31177 to
99ad5c5
Compare
Pull Request Test Coverage Report for Build 9669683508Details
💛 - Coveralls |
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
from
99ad5c5 to
a0248d1
Compare
Pull Request Test Coverage Report for Build 9700099017Details
💛 - Coveralls |
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
2 times, most recently
from
e62a4fc to
e53223b
Compare
Pull Request Test Coverage Report for Build 9936217495Details
💛 - Coveralls |
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
4 times, most recently
from
3225860 to
ec57ca7
Compare
HenningHolmDE
changed the title
imap-codecimap-codec
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
from
ec57ca7 to
ba7c2e2
Compare
jakoschiko
reviewed
Jul 13, 2024
duesee
approved these changes
Jul 13, 2024
For serialization/deserialization in the Python bindings, add new `serde` feature that is forwarded to `imap-types`.
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
from
ba7c2e2 to
09e900a
Compare
Wrap codecs from `imap-codec` into `pyobject` types to be used from Python. For each of the codecs, the `decode` method is implemented and corresponding Python tests are added to prevent regressions on the bindings. The encoding implementation will be added in a subsequent commit. Currently, the resulting `dict`/`tuple` types are still very rough which should be changed further down the road.
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
from
09e900a to
d7c650b
Compare
Merged
As the encoded fragments will deserialized into Python objects, `Fragment` has to implement `Serialize`.
Add `encode` methods to the Python wrappers for the codecs and Python tests for each encoder. Currently, the `dict`/`tuple` types are still very rough, which should be changed further down the road.
This adds Python examples `parse_command`, `parse_greeting` and `parse_response`, which are translated from the Rust examples available for `imap-codec`.
HenningHolmDE
force-pushed
the
issue_359_python_bindings
branch
from
d7c650b to
9efadeb
Compare
|
@duesee I think, I've now resolved all open questions or created issues for further tracking. As usual, I've tried to put independent changes into separate commits for easier tracibility lateron, so you might not want to squash them. |
|
Thanks! Let's get this in then! 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first iteration of Python bindings for
imap-codec.The first iteration aims to provide a first "usable" version wich a very rough API through
dict/tupletypes. Switching these types to provide a more Pythonic API should be achieved lateron:Command,Greeting) -> binding(Python): Use Python classes for codec messages #559This would make it more clear what the methods accept and return, even if these classes itself are constructed from dictionaries.
Fragmentvariants (LineFragment,LiteralFragment) -> bindings(Python): Use Python classes forFragmentvariants #560Note: This would remove the need for
Fragmentto implementSerialize, so it might make sense to do this before the next release ofimap-codec.Also, before releasing a first Python package to PyPI, these things should probably be considered: