Skip to content

Commit

Permalink
feat(netutil): add async http request for http client (#256)
Browse files Browse the repository at this point in the history
* fix(algorithm): fix bug of lrucache in issue #251

* feat(netutil): add async send request for HttpClient
  • Loading branch information
aki-colt authored Oct 18, 2024
1 parent 1008dd4 commit 1671f78
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 0 deletions.
16 changes: 16 additions & 0 deletions netutil/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,22 @@ func (client *HttpClient) SendRequest(request *HttpRequest) (*http.Response, err
return resp, nil
}

// AsyncSendRequest send http request with goroutine, pop response and error to channels
func (client *HttpClient) AsyncSendRequest(request *HttpRequest, respChan chan *http.Response, errChan chan error) {
go func() {
defer func() {
if err := recover(); err != nil {
errChan <- fmt.Errorf("%v", err)
}
}()
resp, err := client.SendRequest(request)
if err != nil {
errChan <- err
}
respChan <- resp
}()
}

// DecodeResponse decode response into target object.
// Play: https://go.dev/play/p/jUSgynekH7G
func (client *HttpClient) DecodeResponse(resp *http.Response, target any) error {
Expand Down
39 changes: 39 additions & 0 deletions netutil/http_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,45 @@ func TestSendRequestWithFilePath(t *testing.T) {
}
}

func TestHttpClient_AsyncSendRequest(t *testing.T) {
t.Parallel()

assert := internal.NewAssert(t, "TestHttpClient_Get")

request := &HttpRequest{
RawURL: "https://jsonplaceholder.typicode.com/todos/1",
Method: "GET",
}

httpClient := NewHttpClient()
respCh := make(chan *http.Response, 20)
errCh := make(chan error, 20)
for i := 0; i < 50; i++ {
httpClient.AsyncSendRequest(request, respCh, errCh)
}
for i := 0; i < 50; i++ {
select {
case resp := <-respCh:
type Todo struct {
UserId int `json:"userId"`
Id int `json:"id"`
Title string `json:"title"`
Completed bool `json:"completed"`
}
var todo Todo
err := httpClient.DecodeResponse(resp, &todo)
if err != nil {
t.FailNow()
}
assert.Equal(1, todo.Id)
case err := <-errCh:
if err != nil {
t.Log("net error: ", err.Error())
}
}
}
}

func TestProxy(t *testing.T) {
config := &HttpClientConfig{
HandshakeTimeout: 20 * time.Second,
Expand Down

0 comments on commit 1671f78

Please sign in to comment.