[6.x] Prevent passing the cart to the view #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request prevents the
cartvariable from being passed from SC's controllers into the view.Normally, when using entries, there's no issue with this. However, when using database orders and Runway v6, some of the raw augmented data contains query builders, which contain PDO objects which can't be serialized, leading to an error (#1003).
The easiest way to fix this is to just prevent the
cartvariable from being passed into the view. I can't find anywhere we're actually using the passed downcartvariable in the docs or the starter kit and can't think of a case where you'd want it over using the{{ sc:cart }}tag.We are still returning the
cartdata from the action controllers though but just for JSON responses where it doesn't seem to be an issue (probably because they get serialized differently).Fixes #1003.