[6.x] Query Builders #973
Merged
[6.x] Query Builders #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the "current repository" in this case would be the eloquent one so Customer::query() wouldn't pick up old customers.
…commerce into query-builder
…commerce into query-builder
# Conflicts: # src/Widgets/TopCustomers.php
|
Released as part of v6.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements query builders for products, orders & customers.
This means we can use the same query across multiple repositories which was previously not possible as you had to implement the same-ish query two/three times depending on the repository in use.
The query builders extend the
EntryQueryBuilderandEloquentQueryBuilderthat are built into Statamic.This PR shouldn't make much of a difference to end-developers, apart from the fact
Product::all()/Customer::all()/Order::all()will now return Simple Commerce objects, rather than entries/Eloquent models.This PR also improves the state of testing around the various product/order/customer repositories.
To Do
idcolumn in Eloquent queries actually queries whatever the model key is.