Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v4): upgrade corenlp to v4 #19

Merged
merged 1 commit into from
Apr 10, 2021
Merged

feat(v4): upgrade corenlp to v4 #19

merged 1 commit into from
Apr 10, 2021

Conversation

duncdrum
Copy link
Owner

Updates the core libraries to v 4.2.0 see https://github.com/lcahlander/exist-stanford-nlp/issues/10

tested and working

we could make this more efficient by using maven's templating to updated the version inside config.xqm

@todo
Copy link

todo bot commented Apr 10, 2021

(DP): use maven templating to construct version here :)

(: TODO(DP): use maven templating to construct version here :)
declare variable $config:corenlp-version := '4.2.0';
declare variable $config:corenlp-model-url := 'http://nlp.stanford.edu/software/stanford-corenlp-' || $config:corenlp-version ||'-models-';
(:~
: Resolve the given path using the current application context.


This comment was generated by todo based on a TODO comment in d5e8656 in #19. cc @duncdrum.

@duncdrum duncdrum merged commit e6f6612 into deps-updates Apr 10, 2021
@similar-code-searcher
Copy link

Similar files are

2 similar comments
@similar-code-searcher
Copy link

Similar files are

@similar-code-searcher
Copy link

Similar files are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant