Skip to content

Commit

Permalink
bugfixes: create_query is_private field name & add optional arguments…
Browse files Browse the repository at this point in the history
… to run_sql() (#103)

* create_query(): fix argument, field is is_private, not private
* run_sql(): add optional argument to specify performance
* run_sql(): add optional argument to name the query
* bump max args to 10 on lint rules
  • Loading branch information
agaperste authored Nov 23, 2023
1 parent ac29a0f commit aef5949
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[MASTER]
disable=fixme,logging-fstring-interpolation
disable=fixme,logging-fstring-interpolation
[DESIGN]
max-args=10
6 changes: 4 additions & 2 deletions dune_client/api/extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,15 +195,17 @@ def run_sql(
params: Optional[list[QueryParameter]] = None,
is_private: bool = True,
archive_after: bool = True,
performance: Optional[str] = None,
name: str = "API Query",
) -> ResultsResponse:
"""
Allows user to provide execute raw_sql via the CRUD interface
- create, run, get results with optional archive/delete.
- Query is by default made private and archived after execution.
Requires premium subscription!
"""
query = self.create_query("API Query", query_sql, params, is_private)
results = self.run_query(query.base)
query = self.create_query(name, query_sql, params, is_private)
results = self.run_query(query=query.base, performance=performance)
if archive_after:
self.archive_query(query.base.query_id)
return results
Expand Down
2 changes: 1 addition & 1 deletion dune_client/api/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def create_query(
payload = {
"name": name,
"query_sql": query_sql,
"private": is_private,
"is_private": is_private,
}
if params is not None:
payload["parameters"] = [p.to_dict() for p in params]
Expand Down

0 comments on commit aef5949

Please sign in to comment.