Add support for new features on query results #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for a few features that will soon become available when retrieving query results: - specify the output columns - get a sample of the results - filter out some rows before retrieve the results - sort the results
RichardKeo
changed the title
| if filters is not None: | ||
| params["filters"] = filters | ||
| if sort_by is not None and len(sort_by) > 0: | ||
| params["sort_by"] = ",".join(sort_by) |
There was a problem hiding this comment.
Wouldn't you want to do the escaping here too?
There was a problem hiding this comment.
No, this will be the user's responsibility since we can't reliably do it. The way they'll specify the order is something like this:
sort_by=['column_1', '"column 2" DESC', '"column\\" 3" ASC']This should then get converted to the following:
column_1,"column 2" DESC,"column\\" 3" ASC
There was a problem hiding this comment.
Ah makes sense. We'll have to check for SQL injection then tho, right?
Comment on lines
+62
to
+67
| assert ( | ||
| # We are not sampling | ||
| sample_count is None | ||
| # We are sampling and don't use filters or pagination | ||
| or (batch_size is None and filters is None) | ||
| ), "sampling cannot be combined with filters or pagination" |
There was a problem hiding this comment.
Isn't this already covered by the assert on the build params function?
There was a problem hiding this comment.
It would, but it would only run after the refresh
Comment on lines
+104
to
+109
| assert ( | ||
| # We are not sampling | ||
| sample_count is None | ||
| # We are sampling and don't use filters or pagination | ||
| or (batch_size is None and filters is None) | ||
| ), "sampling cannot be combined with filters or pagination" |
TheEdgeOfRage
approved these changes
Mar 1, 2024
msf
approved these changes
Mar 4, 2024
| @@ -114,6 +179,14 @@ def get_latest_result( | |||
| :param max_age_hours: re-executes the query if result is older than max_age_hours | |||
| https://dune.com/docs/api/api-reference/get-results/latest-results | |||
There was a problem hiding this comment.
Will follow up in a separate PR to update all links to the docs (we do have a redirect tho)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a few features that will soon become available when retrieving query results: