Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeroex - update eth native taker #6256

Merged
merged 119 commits into from
Jul 12, 2024

Conversation

RantumBits
Copy link
Contributor

zeroex - update taker on native swaps

RantumBits and others added 30 commits June 1, 2021 14:07
@dune-eng
Copy link

Workflow run id 9669601910 approved.

@dune-eng
Copy link

Workflow run id 9669602226 approved.

@dune-eng
Copy link

Workflow run id 9669602288 approved.

@dune-eng
Copy link

Workflow run id 9670114357 approved.

@dune-eng
Copy link

Workflow run id 9670114576 approved.

@dune-eng
Copy link

Workflow run id 9670114581 approved.

@dune-eng
Copy link

Workflow run id 9670129859 approved.

@dune-eng
Copy link

Workflow run id 9670130069 approved.

@dune-eng
Copy link

Workflow run id 9670130060 approved.

@dune-eng
Copy link

Workflow run id 9670135574 approved.

@dune-eng
Copy link

Workflow run id 9670135875 approved.

@dune-eng
Copy link

Workflow run id 9670135877 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @RantumBits

Comment on lines 259 to 264
{% if is_incremental() %}
AND {{ incremental_predicate('tp.minute') }}
{% endif %}
{% if not is_incremental() %}
AND evt_block_time >= TIMESTAMP '{{zeroex_v3_start_date}}'
{% endif %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The incremental filters are removed for prices join, but this change may have minor impact.

@dune-eng
Copy link

Workflow run id 9878705307 approved.

@dune-eng
Copy link

Workflow run id 9878705581 approved.

@dune-eng
Copy link

Workflow run id 9878705579 approved.

@jeff-dude jeff-dude self-assigned this Jul 10, 2024
@jeff-dude jeff-dude merged commit 6a04b61 into duneanalytics:main Jul 12, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@RantumBits RantumBits deleted the eth-native-taker branch August 9, 2024 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants