Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix dex fix #6281

Merged
merged 34 commits into from
Jul 4, 2024
Merged

Phoenix dex fix #6281

merged 34 commits into from
Jul 4, 2024

Conversation

andrewhong5297
Copy link
Collaborator

redo phoenix fix without seed

Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge when CI passes ✔️
I've made a couple small adjustments that should also be replicated once we remove columns from other base spells.

  1. rename the model to _base_trades
  2. add the check_columns_solana_dex_trades schema test
  3. add a compatibility view at the old model name, @aalan3 notified me these solana dex models do see some usage on the base level so we try and not break those user queries.

@andrewhong5297
Copy link
Collaborator Author

Looks good to merge when CI passes ✔️ I've made a couple small adjustments that should also be replicated once we remove columns from other base spells.

  1. rename the model to _base_trades
  2. add the check_columns_solana_dex_trades schema test
  3. add a compatibility view at the old model name, @aalan3 notified me these solana dex models do see some usage on the base level so we try and not break those user queries.

good callouts and foresight! I'll copy the same pattern for meteora/goose when I get to it later today/tomorrow

@aalan3 aalan3 merged commit bc212ad into main Jul 4, 2024
1 of 2 checks passed
@aalan3 aalan3 deleted the phoenix-dex-fix branch July 4, 2024 07:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: solana covers the Solana dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants