-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Hourly Spellbook subproject #6401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in addition to the minor comments below:
- any reason we don't move project specific macros to their new subproject, i.e. all the balancer macros to
hourly_spellbook/macros/
? i think we're gonna have some follow up cleaning to do in terms of getting all macros in the correct spot, across various projects - can we use this PR to continue moving more around and finalize the projects? my thought was to reuse the existing dbt cloud project and cluster for
hourly_spellbook
, then all others move to their final spots too, which would require no extra setup since already done. that would mean pushing all remaining spells todaily_spellbook
project within this PR too. otherwise, we'll have to set up new dbt cloud project, new cluster, to supporthourly_spellbook
while we continue to run the other jobs on legacy
hourly_spellbook/models/_sector/staking/solana/staking_solana_schema.yml
Outdated
Show resolved
Hide resolved
hourly_spellbook/models/_sector/staking/solana/staking_solana_stake_actions.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason transfers has its own source file here rather than add to _sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no particular reason, I was trying some new formats out to see how we can clean up the shared sources in the future.
I think I do prefer this setup with some more structure and split into more different files.
From a dbt standpoint this doesn't matter at all so it's just a repository organisation question.
good point, will clean them up while we're at it. 👍
Initially I wanted to limit the PR to just splitting out the hourly models (as it is already huge). |
yeah github is not liking these big PRs, will revert and split back into 2. |
dcebe65
to
8716f9b
Compare
@jeff-dude my advise would be to merge this, setup a new dbt cloud job for hourly spellbook but re-use the current legacy cluster. |
I'm closing this and reopening the PR here (#6421) from a branch within the spellbook repo (instead of my fork). |
tokens
subproject: