Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lending.supply - add repay with atokens evt #6447

Merged

Conversation

tomfutago
Copy link
Contributor

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

For bug fixes

If you are fixing a bug, please provide the following information:


@dune-eng
Copy link

Workflow run id 10124209934 approved.

@defispartan
Copy link
Contributor

Hey @tomfutago, any estimate on when you think think this will be ready?

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10199969076 approved.

@tomfutago
Copy link
Contributor Author

Hey @tomfutago, any estimate on when you think think this will be ready?

hey @defispartan hopefully by end of the week 🤞

atm dbt-test seems to be stuck for some reason. @jeff-dude @Hosuke is this because I'm only changing macro? thought this will trigger all spells relying on it to re-run?

@jeff-dude
Copy link
Member

is this because I'm only changing macro? thought this will trigger all spells relying on it to re-run?

i've noticed this pattern on a few PRs lately. odd for sure. for now, if you don't mind, maybe push a model (or a few) into PR to get to run?

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200815584 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200815466 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200941372 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200941761 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10201047628 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10201047641 approved.

@dune-eng
Copy link

dune-eng commented Aug 4, 2024

Workflow run id 10235540845 approved.

@dune-eng
Copy link

dune-eng commented Aug 4, 2024

Workflow run id 10235540937 approved.

@dune-eng
Copy link

dune-eng commented Aug 4, 2024

Workflow run id 10236985451 approved.

@dune-eng
Copy link

dune-eng commented Aug 4, 2024

Workflow run id 10236985437 approved.

@foodaka
Copy link

foodaka commented Aug 8, 2024

hey @tomfutago any update on this one?

@tomfutago
Copy link
Contributor Author

hey @foodaka - this PR is ready for review and it's in dune team hands now + comments on #6417 issue.

just one note tho:
@jeff-dude there's a conflict on supply macro, but gh doesn't allow me to resolve it - I was able to resolve merge conflict before 🤔

@jeff-dude
Copy link
Member

hey @foodaka - this PR is ready for review and it's in dune team hands now + comments on #6417 issue.

just one note tho: @jeff-dude there's a conflict on supply macro, but gh doesn't allow me to resolve it - I was able to resolve merge conflict before 🤔

i'll look at it all today, thanks for getting it ready 🙏

@jeff-dude jeff-dude self-assigned this Aug 8, 2024
@jeff-dude jeff-dude added the in review Assignee is currently reviewing the PR label Aug 8, 2024
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!

@jeff-dude jeff-dude linked an issue Aug 8, 2024 that may be closed by this pull request
@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Aug 8, 2024
@jeff-dude jeff-dude merged commit 7cfc9d4 into duneanalytics:main Aug 8, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Discrepencies with Aave total supplied values in lending.supply
5 participants