Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure macros #6450

Merged
merged 4 commits into from
Aug 6, 2024
Merged

restructure macros #6450

merged 4 commits into from
Aug 6, 2024

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Jul 29, 2024

restructure macros:

  • dbt_macros/deprecated_udfs -> these are not used anymore afaik

  • dbt_macros/dune -> Dune specific backend macros

  • dbt_macros/generic-tests -> generic test definitions

  • dbt_macros/shared -> macros used in multiple subprojects

  • dbt_subprojecs/<project>/macros -> macros used in the specific subproject

.gitignore Show resolved Hide resolved
@0xRobin 0xRobin marked this pull request as ready for review July 29, 2024 10:00
@0xRobin 0xRobin added ready-for-review this PR development is complete, please review dune team created by dune team labels Jul 29, 2024
@0xRobin 0xRobin requested review from jeff-dude and Hosuke July 29, 2024 10:42
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can have a readme to index and guide to use these macros.

@0xRobin
Copy link
Collaborator Author

0xRobin commented Jul 29, 2024

Maybe we can have a readme to index and guide to use these macros.

I would point people to docs/macros/macro_overview.md

.gitignore Show resolved Hide resolved
dbt_macros/deprecated_udfs/base58_decode.sql Show resolved Hide resolved
@jeff-dude
Copy link
Member

let's talk about this setup in our weekly tomorrow. i mostly agree, just want to finalize together

@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jul 31, 2024
@jeff-dude
Copy link
Member

gonna focus on some merges today, so will keep this one queued up for a quiet day

@jeff-dude jeff-dude self-assigned this Aug 1, 2024
@jeff-dude jeff-dude added ready-for-final-review and removed in review Assignee is currently reviewing the PR labels Aug 1, 2024
@jeff-dude jeff-dude merged commit 79162f2 into duneanalytics:main Aug 6, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dune team created by dune team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants