Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safes models on linea #6473

Merged
merged 36 commits into from
Aug 7, 2024
Merged

Conversation

danielpartida
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@dune-eng
Copy link

Workflow run id 10179333329 approved.

@dune-eng
Copy link

Workflow run id 10179334028 approved.

@dune-eng
Copy link

Workflow run id 10179391697 approved.

@dune-eng
Copy link

Workflow run id 10179391994 approved.

@dune-eng
Copy link

Workflow run id 10179402073 approved.

@dune-eng
Copy link

Workflow run id 10179402290 approved.

@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review WIP work in progress and removed ready-for-review this PR development is complete, please review labels Jul 31, 2024
@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10280834785 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10280835337 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10280836952 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10280837521 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10280838947 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10280839214 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10280840569 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10280840525 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282186245 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282186345 approved.

@danielpartida
Copy link
Contributor Author

Thank you for the comments @jeff-dude, just included them to the Safe Linea models

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282210632 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282211180 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282579336 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282579677 approved.

@jeff-dude jeff-dude self-assigned this Aug 7, 2024
@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress labels Aug 7, 2024
@jeff-dude jeff-dude merged commit 4b55c68 into duneanalytics:main Aug 7, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
@danielpartida danielpartida deleted the add-safes-linea branch September 19, 2024 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants