Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block_time and block_slot to solana_utils balances #6539

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

enriquerodbe
Copy link
Contributor

Contribution type

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Description

Add block_time and block_slot to solana_utils.latest_balances and solana_utils.daily_balances


Additional information

Copy link

github-actions bot commented Aug 9, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dune-eng
Copy link

dune-eng commented Aug 9, 2024

Workflow run id 10325999463 approved.

@dune-eng
Copy link

dune-eng commented Aug 9, 2024

Workflow run id 10325999656 approved.

@enriquerodbe
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 9, 2024
@enriquerodbe
Copy link
Contributor Author

recheck

@jeff-dude jeff-dude linked an issue Aug 9, 2024 that may be closed by this pull request
@jeff-dude
Copy link
Member

you're all set on signing the CLA. CI builds are just failing due to cluster crashes on large solana volumes of data. i will have to help get this to run early next week.

@jeff-dude jeff-dude self-assigned this Aug 9, 2024
@jeff-dude jeff-dude added the in review Assignee is currently reviewing the PR label Aug 9, 2024
@jeff-dude
Copy link
Member

since this change is a simple column add, my goal here is to push a test commit to shrink the timeframe of historical data to make this much less compute intensive on the cluster. i would be comfortable with this change on portions of history.

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good with me here after the tests ran 🙏

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Aug 12, 2024
@dune-eng
Copy link

Workflow run id 10371593302 approved.

@dune-eng
Copy link

Workflow run id 10371593730 approved.

@jeff-dude
Copy link
Member

manually canceling CI. i am prepping prod for this merge now.

@jeff-dude jeff-dude merged commit 4a6999c into duneanalytics:main Aug 13, 2024
1 of 2 checks passed
Copy link

gitpoap-bot bot commented Aug 13, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Dune Contributor:

GitPOAP: 2024 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add block_slot column to solana_utils.latest_balances
3 participants