fix: make bonkbot spellbook entries unique again #7083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeff-dude uniqueness test is now passing, before merging pls revert start date back to original value (seed is failing since seed is from older trades, not in the current start date) |
jeff-dude
added
ready-for-review
jeff-dude
approved these changes
Nov 6, 2024
jeff-dude
added
ready-for-merging
and removed
ready-for-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After @jeff-dude reported uniqueness failures in #7057 , this PR fixes them
update:
duplicate is apparently this 4QniYgvGt64cybTo7VfktR7riBt4VqA7PTnsNSP6RpbqprN6hD6rAWdhzkp81YJ8CNhvuqfG7DuHBcVdFSh4MWZk
receives both SOL + a SPL deposit in the same tx