Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solana dex.trades issue #7119

Merged
merged 10 commits into from
Nov 8, 2024
Merged

Fix solana dex.trades issue #7119

merged 10 commits into from
Nov 8, 2024

Conversation

0xBoxer
Copy link
Collaborator

@0xBoxer 0xBoxer commented Nov 7, 2024

This PR is to trigger a run of dex.trades to investigate the issue with token22 null values.

@0xBoxer
Copy link
Collaborator Author

0xBoxer commented Nov 7, 2024

this seems to work in getting the volumes back to normal:

run against dex.trades with inflated volumes: https://dune.com/queries/4257936/7161008
run against CI output with normal volumes: https://dune.com/queries/4258732/7161316

@0xBoxer 0xBoxer changed the title Trigger dex.trades run to check for token22 null values issue Fix solana dex.trades issue Nov 7, 2024
@jeff-dude
Copy link
Member

i will move the changes to native sol transfers here to other PR, so i can merge that one alone first

@jeff-dude jeff-dude self-assigned this Nov 8, 2024
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR dbt: solana covers the Solana dbt subproject labels Nov 8, 2024
@jeff-dude
Copy link
Member

as noted in slack, should be good to remove here without modified enabled and increased incremental read back timeframe. that will need handled in dbt cloud manually.

to confirm, changes here:

  • no logic change in dex pipeline, just need to refresh data with how it joins to fixed transfers data (in progress now)
  • unique key change on sol transfer current model, no impact on history, just logic moving forward

@jeff-dude jeff-dude added ready-for-merging blocked and removed in review Assignee is currently reviewing the PR blocked labels Nov 8, 2024
@jeff-dude jeff-dude merged commit 29b53d8 into main Nov 8, 2024
1 of 2 checks passed
@jeff-dude jeff-dude deleted the test-solana-dex-trades-fix branch November 8, 2024 05:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: solana covers the Solana dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants