Unmaterialise blobs.based_submitters
#7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hildobby
added
easy
ready-for-review
jeff-dude
approved these changes
Nov 17, 2024
jeff-dude
added
ready-for-merging
and removed
ready-for-review
|
noting for self: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
blobs.based_submittersnot always up to date prior toethereum.blobsruns, it leads to some accidentally untagged blobs when they should be tagged, like here you can see all those untagged from nov 7th onwards showing up when they should be tagged as taiko:It's also misleading people who think those are new blob submitters: https://x.com/trent_vanepps/status/1855170775915065474
And regardless, blobs.based_submitters currently runs in ~2 seconds so this should be no big deal in terms of compute/runtime