Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing amms for jupiter tracking #7483

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

ckamm
Copy link
Contributor

@ckamm ckamm commented Jan 17, 2025

Description

The jupiter tracking table contains a list of amms updated from the list available via jupiter api: https://station.jup.ag/api-v6/get-program-id-to-label .

I made sure all amms that were reported by the api are present in the query's list.

The list was previously updated this way in #7131

Done by querying https://station.jup.ag/api-v6/get-program-id-to-label
and ensuring all amms listed there are present.
@github-actions github-actions bot marked this pull request as draft January 17, 2025 10:48
@github-actions github-actions bot added the WIP work in progress label Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added the dbt: solana covers the Solana dbt subproject label Jan 17, 2025
@ckamm
Copy link
Contributor Author

ckamm commented Jan 17, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 17, 2025
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for using git history to find example how to add & welcome to spellbook!

@jeff-dude jeff-dude self-assigned this Jan 17, 2025
@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress labels Jan 17, 2025
@ckamm
Copy link
Contributor Author

ckamm commented Jan 20, 2025

Thanks @jeff-dude! Is there something I still need to do before this can be merged? I see a "Ready for review" button, but it already has a ready-for-merging tag, so I'm a bit confused.

@ckamm ckamm marked this pull request as ready for review January 20, 2025 09:10
@github-actions github-actions bot added the ready-for-review this PR development is complete, please review label Jan 20, 2025
@jeff-dude
Copy link
Member

Thanks @jeff-dude! Is there something I still need to do before this can be merged? I see a "Ready for review" button, but it already has a ready-for-merging tag, so I'm a bit confused.

no, all good! i just didn't want to merge on a friday, since solana jobs take more time + compute in prod to rebuild. as for the labels, the ready for review got auto-applied due to promoting the PR to ready state. i should've done that for ya friday, my fault! i'll remove that one to avoid confusion.

@jeff-dude jeff-dude removed the ready-for-review this PR development is complete, please review label Jan 20, 2025
@jeff-dude jeff-dude merged commit 801cfa7 into duneanalytics:main Jan 20, 2025
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: solana covers the Solana dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants