version update, method name update

duosecurity · Jul 25, 2024 · b8cf2aa · b8cf2aa
1 parent 31760b1
commit b8cf2aa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/DuoUniversal/Client.cs b/DuoUniversal/Client.cs
@@ -130,12 +130,12 @@ private async Task<TokenResponse> ExchangeAuthorizationCodeResponse(string duoCo
         }
 
         /// <summary>
-        /// Send the authorization code provided by Duo back to Duo in exchange for a full Duo response.
+        /// Extracts and validates the Id Token from the response.
         /// Will raise a DuoException if the username does not match the Id Token.
         /// </summary>
         /// <param name="duoCode">The one-time use code issued by Duo</param>
         /// <returns>A TokenResponse authenticating the user and describing the authentication</returns>
-        private IdToken IdTokenFromResponse(TokenResponse tokenResponse, string username)
+        private IdToken ValidateIdTokenFromResponse(TokenResponse tokenResponse, string username)
         {
             IdToken idToken;
             try
@@ -169,7 +169,7 @@ private IdToken IdTokenFromResponse(TokenResponse tokenResponse, string username
         public async Task<IdToken> ExchangeAuthorizationCodeFor2faResult(string duoCode, string username)
         {
             TokenResponse tokenResponse = await ExchangeAuthorizationCodeResponse(duoCode);
-            return IdTokenFromResponse(tokenResponse, username);
+            return ValidateIdTokenFromResponse(tokenResponse, username);
 
         }
 
@@ -184,10 +184,11 @@ public async Task<string> ExchangeAuthorizationCodeForSamlResponse(string duoCod
         {
             string samlResponse;
             TokenResponse tokenResponse = await ExchangeAuthorizationCodeResponse(duoCode);
-            //checking if the IdToken valid before assigning saml response
+
             try
             {
-                IdTokenFromResponse(tokenResponse, username);
+                // Calling this method to validate the token, before getting the samlResponse value
+                ValidateIdTokenFromResponse(tokenResponse, username);
                 samlResponse = tokenResponse.SamlResponse;
             }
             catch (Exception e)

diff --git a/DuoUniversal/DuoUniversal.csproj b/DuoUniversal/DuoUniversal.csproj
@@ -6,7 +6,7 @@
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;net471</TargetFrameworks>
     <PackageId>DuoUniversal</PackageId>
-    <Version>1.3.0</Version>
+    <Version>1.2.6</Version>
     <Authors>Duo Security</Authors>
     <Company>Duo Security</Company>
     <Copyright>Cisco Systems, Inc. and/or its affiliates</Copyright>