Update example to work with PHP 8 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyparker
force-pushed
the
php8_example
branch
3 times, most recently
from
3576fd2 to
8187423
Compare
jeffreyparker
force-pushed
the
php8_example
branch
from
8187423 to
e35f1f5
Compare
mbish
reviewed
Oct 23, 2023
mbish
approved these changes
Oct 23, 2023
|
LGTM I just had one question but it's not blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the example to be compatible with PHP 8 by updating the slim dependencies and fixing a warning with the http_proxy array access. Slim no longer supports PHP 7.3, so also dropping support for that. (PHP 7.3 was EOL 12/2021. PHP 7.4 is also EOL, but still heavily used)
Motivation and Context
The example should work with all currently-supported versions of PHP.
How Has This Been Tested?
Manually verified locally, and added basic example app validation to the CI testing.
Types of Changes