Change how sysconfdir is used to be more inline with how systems expect #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number being addressed
On Fedora-based systems
/usr/share/config.sitemesses with the way that we install configurationfiles for duo. Currently we modify
sysconfdirat configuration time in order to point to/etc/duo.I think we should rather let
sysconfdirremain as an indicator of the system configuration directory(e.g
/etc) and add subdirectories as necessary.Summary of the change
sysconfdirnow points to${prefix}/etcinstead of${prefix}/etc/duo.Test Plan
This change has been manually tested on a current Ubuntu and Fedora machine.