Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: change finalization order to support new piecrust #3493

Merged
merged 2 commits into from
Feb 13, 2025
Merged

node: change finalization order to support new piecrust #3493

merged 2 commits into from
Feb 13, 2025

Conversation

herr-seppia
Copy link
Member

Change the finalization order according to the ABI_SENDER feature activation

See also #3341

miloszm
miloszm requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finalization part looks good but some questions about unrelated changes

rusk/src/lib/node.rs Show resolved Hide resolved
rusk/src/lib/node/vm.rs Show resolved Hide resolved
@miloszm miloszm self-requested a review February 13, 2025 14:51
@herr-seppia herr-seppia merged commit d4e7f32 into master Feb 13, 2025
16 checks passed
@herr-seppia herr-seppia deleted the finalization_activation branch February 13, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszm miloszm miloszm approved these changes

@HDauven HDauven Awaiting requested review from HDauven

@Neotamandua Neotamandua Awaiting requested review from Neotamandua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herr-seppia @miloszm