Skip to content

Commit

Permalink
[front/components/spaces] - feature: pass systemSpace to dataSource v…
Browse files Browse the repository at this point in the history
…iews modal

 - Include the systemSpace prop in EditSpaceManagedDataSourcesViews to be utilized within the SpaceManagedDataSourcesViewsModal
 - Replace space with systemSpace when rendering the DataSourceViewPicker in the modal to ensure it operates with the correct space context
  • Loading branch information
JulesBelveze committed Mar 6, 2025
1 parent b875389 commit 3bf51f2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ export function EditSpaceManagedDataSourcesViews({
<>
<SpaceManagedDatasourcesViewsModal
space={space}
systemSpace={systemSpace}
isOpen={showDataSourcesModal}
onClose={() => {
setShowDataSourcesModal(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ interface SpaceManagedDataSourcesViewsModalProps {
owner: WorkspaceType;
systemSpaceDataSourceViews: DataSourceViewType[];
space: SpaceType;
systemSpace: SpaceType;
}

export default function SpaceManagedDataSourcesViewsModal({
Expand All @@ -56,6 +57,7 @@ export default function SpaceManagedDataSourcesViewsModal({
owner,
systemSpaceDataSourceViews,
space,
systemSpace,
}: SpaceManagedDataSourcesViewsModalProps) {
const defaultSelectedDataSources = useStabilizedValue(
initialSelectedDataSources,
Expand Down Expand Up @@ -158,7 +160,7 @@ export default function SpaceManagedDataSourcesViewsModal({
setSelectionConfigurations={setSelectionConfigurationsCallback}
viewType="all"
isRootSelectable={true}
space={space}
space={systemSpace}
/>
</div>
</SheetContainer>
Expand Down

0 comments on commit 3bf51f2

Please sign in to comment.