Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gong users take 2 #11234

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Gong users take 2 #11234

merged 4 commits into from
Mar 5, 2025

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Mar 5, 2025 •
edited
Loading

Description

Follow up of #11232.

This PR:

  • removes the emailAliases row from gong users
  • adds a helper to fetch a batch of user ids from our local database. If some aren't found we will fetch them from the Gong API and store then in our system so we don't need those extra calls later on
  • fixes GongUserResource.bulkCreate() so it update fields on conflict

Tests

Risk

Deploy Plan

  • Deploy connectors
  • Apply SQL migration

@flvndvd flvndvd marked this pull request as ready for review March 5, 2025 16:28
@flvndvd flvndvd added the migration-ack 📁 Label to acknowledge that a migration is required. label Mar 5, 2025
@flvndvd flvndvd changed the title Flav/gong users take 2 Gong users take 2 Mar 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against 3d0d361

aubin-tchoi
aubin-tchoi approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@aubin-tchoi aubin-tchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flvndvd flvndvd merged commit 6e75d27 into main Mar 5, 2025
9 checks passed
@flvndvd flvndvd deleted the flav/gong-users-take-2 branch March 5, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aubin-tchoi aubin-tchoi aubin-tchoi approved these changes

Assignees
No one assigned
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flvndvd @aubin-tchoi