Changed MediaType from byte to int to handle extended vendor type #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r LWM2M TLV encoding (11542/11543)
|
Thanks you @bocajim for the contribution; looks code. Can you please add a short unit tests that encodes and decodes a message with a Content-Type bigger than 255? (just pick one of those OMA-LWM2M types) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IETF is specifying MediaType codes beyond 255:
https://www.iana.org/assignments/core-parameters/core-parameters.xhtml
As such, the type of the field needs to change to something larger and able to handle the other protocols (such as the OMA-LWM2M vendor codes).