Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request to fix cal3-minMax ages bug #19 #24

Merged
merged 8 commits into from
Jun 3, 2019
Merged

Conversation

dwbapst
Copy link
Owner

@dwbapst dwbapst commented Jun 3, 2019

Fixes #19 and implements tests so this behavior never occurs again.

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #24 into master will increase coverage by 6.17%.
The diff coverage is 66.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   16.26%   22.43%   +6.17%     
==========================================
  Files          78       78              
  Lines        8870     8993     +123     
==========================================
+ Hits         1443     2018     +575     
+ Misses       7427     6975     -452
Impacted Files Coverage Δ
R/timePaleoPhy.R 20.22% <ø> (ø) ⬆️
R/cal3TimePaleoPhy.R 58.08% <66.82%> (+58.08%) ⬆️
R/taxa2phylo.R 79.33% <0%> (+12%) ⬆️
R/durationFreq.R 28.96% <0%> (+28.96%) ⬆️
R/pqr2Ps.R 43.75% <0%> (+43.75%) ⬆️
R/dateNodes.R 64.7% <0%> (+64.7%) ⬆️
R/taxa2cladogram.R 83.33% <0%> (+83.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18e9c3...f1a3b2f. Read the comment docs.

@dwbapst dwbapst merged commit cd17457 into master Jun 3, 2019
dwbapst added a commit that referenced this pull request Jun 3, 2019
Merge pull request #24 from dwbapst/developmentBranch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cal3TimePaleoPhy not properly adjusting dates according to dateTreatment = minMax
2 participants