resample audio to 16kHz: #80 #81
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 199 199
=========================================
Hits 199 199 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good and it seems to be working @ndrean .
Instead of opening a new PR, can you add the changes to the README on this one? Just to keep the feature contained to this PR and making it easier for people to go over it in the future = D
ndrean
changed the title
|
@LuchoTurtle |
There was a problem hiding this comment.
Thank you for the changes :)
Just small feedback:
- please refrain from formatting the whole README in these PRs. It makes it difficult to review the changes related to the feature the PR is addressing :P
- I can't really make changes to the PR because you are merging from your
maininstead of creating abranch. So I can't push commits upstream to your fork.
Regardless, awesome PR as always and I really thank you for effort you put in, it's greatly appreciated as always! :D
|
ah, sorry, yes, how stupid, I was on main, I did not pay attention. Git is not my friend. |
Small JS optimisation that resamples the audio from (usually) 48kHz to 16kHz.
JS code only. You can test it.
Next (2/2 for #80) is Readme.