Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for esbuild 0.18 and live reloading #87

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

tauling
Copy link
Contributor

@tauling tauling commented Jul 21, 2023

Hey,

I changed a few things to make esbuild 0.18 and live reloading work on elm code changes. The README should be updated to reflect this. Please let me know what you think about the changes.

Best regards

@tauling
Copy link
Contributor Author

tauling commented Jul 21, 2023

Closes #69

@nelsonic
Copy link
Member

@tauling good plan. When you feel you aren't going to make any further changes click the "Ready for review" button and we will review+merge. Thanks. 👌

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #87 (d4d645e) into main (fce1bd2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines            4         4           
=========================================
  Hits             4         4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic nelsonic marked this pull request as ready for review January 2, 2024 09:43
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tauling 👌

@nelsonic nelsonic merged commit 9b19691 into dwyl:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants