This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
feat(template): Automatically define release #38
Open
ruslan-kurchenko
wants to merge
8
commits into
dxatscale:main
Choose a base branch
from
ruslan-kurchenko:22-update-starter-templates-and-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(template): Automatically define release #38
ruslan-kurchenko
wants to merge
8
commits into
dxatscale:main
from
ruslan-kurchenko:22-update-starter-templates-and-docs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslan-kurchenko
commented
Aug 31, 2023
- Automatically define release file on successful build
@azlam-abdulsalam based on your comment:
|
- Clean from redundant check - Define a correct concurrency of the build jobs
- Naming convention - Create pools without replenishing - Use latest checkout@v4
crazynammer
suggested changes
Oct 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the new line "35" for the reference to "azure pipelines" as this is a github workflow.
The sample pipelines utilize an azure pipelines
crazynammer
reviewed
Oct 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise. Let's do the quick fix, merge, and I'll test it end to end on my personal github and we can find any bugs as needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.