This repository has been archived by the owner on Jan 27, 2022. It is now read-only.
[pull] develop from alphagov:master #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This is to test the pre-release out of 4.0.0. Further details are in: alphagov/rubocop-govuk#129
rubocop -A
Update rubocop-govuk to 4.0.0.pre.1
Bumps [govuk_app_config](https://github.com/alphagov/govuk_app_config) from 2.8.3 to 2.8.4. - [Release notes](https://github.com/alphagov/govuk_app_config/releases) - [Changelog](https://github.com/alphagov/govuk_app_config/blob/master/CHANGELOG.md) - [Commits](alphagov/govuk_app_config@v2.8.3...v2.8.4) Signed-off-by: dependabot[bot] <[email protected]>
In #283, we added code to capture `Addressable::URI::InvalidURIError` exceptions and return 400 Bad Request responses. This was in order to prevent logging this unactionable error in Sentry: https://sentry.io/organizations/govuk/issues/2086648123/?project=202210&referrer=slack The fix didn't work, because we capture the exception too late in the logic, after `context.request.path` and `context.host.nil?` have been called in `Bouncer::App.call`. By this point, the exception has been raised already, before we have had a chance to call `context.valid?`, so the Sentry errors have still been happening. We now check `context.valid?` as the very first thing before digging into its internals.
…nfig-2.8.4 Bump govuk_app_config from 2.8.3 to 2.8.4
Return `Outcome::BadRequest` early if bad request
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.10 to 1.11.0. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.10...v1.11.0) Signed-off-by: dependabot[bot] <[email protected]>
Bump nokogiri from 1.10.10 to 1.11.0
Bumps [activerecord](https://github.com/rails/rails) from 6.0.3.2 to 6.0.3.5. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v6.1.3/activerecord/CHANGELOG.md) - [Commits](rails/rails@v6.0.3.2...v6.0.3.5) Signed-off-by: dependabot[bot] <[email protected]>
…-6.0.3.5 Bump activerecord from 6.0.3.2 to 6.0.3.5
Bumps [govuk_app_config](https://github.com/alphagov/govuk_app_config) from 2.8.4 to 2.9.1. - [Release notes](https://github.com/alphagov/govuk_app_config/releases) - [Changelog](https://github.com/alphagov/govuk_app_config/blob/master/CHANGELOG.md) - [Commits](alphagov/govuk_app_config@v2.8.4...v2.9.1) Signed-off-by: dependabot[bot] <[email protected]>
…nfig-2.9.1 Bump govuk_app_config from 2.8.4 to 2.9.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )