Add basic app working test #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes were merged to the app that caused it to be unable to boot up. We didn't notice this until someone tried to load up the deployed site. Non-major Renovate dependency PRs are merged automatically on this repo, which is risky without at least minimal automated testing. We had a CI workflow to test that the app built but this evidently wasn't sufficient. This adds Playwright so that we can do a basic 'homepage loads' kind of end-to-end test, and run this on CI for pull requests and pushes to main
Per the last commit, this is to ensure automated dependency PRs don't get merged and silently bring the app down
jdudley1123
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes were merged to the app that caused it to be unable to boot up. We didn't notice this until someone tried to load up the deployed site. Non-major Renovate dependency PRs are merged automatically on this repo, which is risky without at least minimal automated testing. We had a CI workflow to test that the app built but this evidently wasn't sufficient. This adds Playwright so that we can do a basic 'homepage loads' kind of end-to-end test, and run this on CI for pull requests and pushes to main
This is part of a restructure of #121, breaking it down into multiple PRs. This covers the last two commits