Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Styling #227

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Improve Styling #227

wants to merge 12 commits into from

Commits on Sep 17, 2024

  1. Add basic CSS vars 

    We can use these as a rudimentary design system to ensure our styling
stays consistent and DRY
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    814d4fb View commit details
    Browse the repository at this point in the history

  2. Implement vars using existing styles 

    We've added the vars, lets use them.
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d21efe8 View commit details
    Browse the repository at this point in the history

  3. Make main fill the viewport 

    This ensures that main fills the full visible viewport
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    627738b View commit details
    Browse the repository at this point in the history

  4. Add column layout 

    This adds a simple column layout with the gameplay area (2/3rds of
viewport) to the left and a column displaying meta information to the
right (1/3 of viewport).
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d3fb44d View commit details
    Browse the repository at this point in the history

  5. Change 'Name:' to 'Your name:' 

    I think this is a little clearer
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2d33ba9 View commit details
    Browse the repository at this point in the history

  6. Move player list into Players & Scores column 

    We also re-add the list styling as I think the bullet points add clarity
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    24e982f View commit details
    Browse the repository at this point in the history

  7. Move Start Button 

    This ensures it displays in the correct place
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b9635f9 View commit details
    Browse the repository at this point in the history

  8. Move gameplay components into their appropriate columns

    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    dd73161 View commit details
    Browse the repository at this point in the history

  9. Move Round reset button 

    Making sure it displays in the correct place
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2014f49 View commit details
    Browse the repository at this point in the history

  10. Add colons to descriptions 

    This makes it a bit clearer these are labels and not just words
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8e18174 View commit details
    Browse the repository at this point in the history

  11. Style colour card section 

    This may make more sense in the colour-card.css file but as it was
styling the top level component I put it in the general css file.
I think it's fine that the colour-cards file doesn't use the CSS vars as
it's a seperate component, but it makes sense for all the components in
this file to.
    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    29ba588 View commit details
    Browse the repository at this point in the history

  12. Style question

    rich committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fe2934e View commit details
    Browse the repository at this point in the history