Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display class subclasses #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

fracek
Copy link
Member

@fracek fracek commented Sep 6, 2014

At the moment it's pretty basic, any idea how I could make this more useful?

Example:

> subclasses <environment-object>
  <warning-object>
  <dylan-object>
  <application>
  <compiler-database>
  <project-object>
  <application-object>
  <compiler-object>
  <environment-options>
  <environment-object-with-library>
  <environment-object-with-id>

specify depth:

> subclasses <environment-object> depth 2
  <warning-object>
    <project-warning-object>
    <compiler-warning-object>
      <compiler-error-object>
      <serious-compiler-warning-object>
  <dylan-object>
    <definition-object>
      <type-object>
      <domain-object>
      <dylan-function-object>
      <constant-object>
      <module-variable-object>
      <macro-object>
      <namespace-object>
    <dylan-compiler-object>
      <expression-object>
    <dylan-application-object>
      <collection-object>
      <symbol-object>
      <immediate-application-object>
  <application>
  <compiler-database>
    <dfmc-database>
  <project-object>
    <native-project-object>
      <dfmc-project-object>
  <application-object>
    <restart-object>
    <stack-frame-object>
    <breakpoint-object>
      <source-location-breakpoint-object>
      <environment-object-breakpoint-object>
    <thread-object>
    <dylan-application-object>
      <collection-object>
      <symbol-object>
      <immediate-application-object>
    <component-object>
    <register-object>
    <address-object>
    <composite-object>
      <collection-object>
      <user-object>
    <application-and-compiler-object>
      <slot-object>
      <type-object>
      <dylan-function-object>
      <variable-object>
      <source-form-object>
    <unbound-object>
    <application-code-object>
      <function-object>
      <source-form-object>
      <foreign-object>
  <compiler-object>
    <compiler-warning-object>
      <compiler-error-object>
      <serious-compiler-warning-object>
    <dylan-compiler-object>
      <expression-object>
    <name-object>
      <binding-name-object>
      <module-name-object>
    <application-and-compiler-object>
      <slot-object>
      <type-object>
      <dylan-function-object>
      <variable-object>
      <source-form-object>
  <environment-options>
  <environment-object-with-library>
    <compiler-warning-object>
      <compiler-error-object>
      <serious-compiler-warning-object>
  <environment-object-with-id>
    <definition-object>
      <type-object>
      <domain-object>
      <dylan-function-object>
      <constant-object>
      <module-variable-object>
      <macro-object>
      <namespace-object>
    <source-form-object>
      <top-level-expression-object>
      <macro-call-object>
    <user-object>
      <duim-object>
      <condition-object>
      <pair-object>
      <range-object>
      <internal-object>

let library = project-library(project);
let object = find-environment-object(project, name,
library: library,
module: first(library-modules(project, library)) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: indentation a bit off in these two lines. no space needed in ")) )"

Does this need a TODO to take the module name as an argument to the "subclasses" command? Or maybe better would be to have a standard notation such as "[[my-lib:]my-mod:]my-name"? Or just search all modules for the name?

@fracek
Copy link
Member Author

fracek commented Sep 7, 2014

I think we should add two flags to the command:

  1. --module module-name to filter by module (maybe a --library too?)
  2. --unique to display ... after encountering an already-seen class

what do you think?

@waywardmonkeys
Copy link
Member

Module and library filters sound good.

I think what Carl said about only printing sub-trees once should be the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants