chore: PR feedback

dylibso · Aug 12, 2023 · cfe8ad6 · cfe8ad6
1 parent 27538cb
commit cfe8ad6
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 8 deletions.
diff --git a/go/adapter/datadog/adapter.go b/go/adapter/datadog/adapter.go
@@ -88,7 +88,6 @@ func (d *DatadogAdapter) Flush(evts []observe.TraceEvent) error {
 		}
 
 		if len(allSpans) == 0 {
-			log.Println("No spans built for datadog trace")
 			return nil
 		}
 

diff --git a/go/adapter/honeycomb/adapter.go b/go/adapter/honeycomb/adapter.go
@@ -18,7 +18,7 @@ import (
 type HoneycombConfig struct {
 	ApiKey             string
 	Dataset            string
-	EmitTracesInterval uint32
+	EmitTracesInterval time.Duration
 	TraceBatchMax      uint32
 	Host               string
 }
@@ -68,7 +68,6 @@ func (h *HoneycombAdapter) Flush(evts []observe.TraceEvent) error {
 		}
 
 		if len(allSpans) == 0 {
-			log.Println("No spans built for honeycomb")
 			return nil
 		}
 

diff --git a/go/adapter/lightstep/adapter.go b/go/adapter/lightstep/adapter.go
@@ -18,7 +18,7 @@ import (
 type LightstepConfig struct {
 	ApiKey             string
 	ServiceName        string
-	EmitTracesInterval uint32
+	EmitTracesInterval time.Duration
 	TraceBatchMax      uint32
 	Host               string
 }
@@ -68,7 +68,6 @@ func (h *LightstepAdapter) Flush(evts []observe.TraceEvent) error {
 		}
 
 		if len(allSpans) == 0 {
-			log.Println("No spans built for lightstep")
 			return nil
 		}
 

diff --git a/go/adapter/otel_stdout/adapter.go b/go/adapter/otel_stdout/adapter.go
@@ -50,7 +50,6 @@ func (o *OtelStdoutAdapter) Flush(evts []observe.TraceEvent) error {
 		}
 
 		if len(allSpans) == 0 {
-			log.Println("No spans built for datadog trace")
 			return nil
 		}
 

diff --git a/go/bin/honeycomb/main.go b/go/bin/honeycomb/main.go
@@ -18,7 +18,7 @@ func main() {
 	conf := &honeycomb.HoneycombConfig{
 		ApiKey:             os.Getenv("HONEYCOMB_API_KEY"),
 		Dataset:            "golang",
-		EmitTracesInterval: 1000,
+		EmitTracesInterval: time.Second * 1,
 		TraceBatchMax:      100,
 		Host:               "https://api.honeycomb.io",
 	}

diff --git a/go/bin/lightstep/main.go b/go/bin/lightstep/main.go
@@ -19,7 +19,7 @@ func main() {
 	conf := &lightstep.LightstepConfig{
 		ApiKey:             os.Getenv("LIGHTSTEP_API_KEY"),
 		ServiceName:        "golang",
-		EmitTracesInterval: 1000,
+		EmitTracesInterval: time.Second * 1,
 		TraceBatchMax:      100,
 		Host:               "https://ingest.lightstep.com",
 	}